jax.Array: support fast path for lax.transpose & lax.squeeze #12311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, what a coincidence! I added support for transpose and squeeze here too: cl/473267301 |
|
Let's get your PR in and I can sync my CL to that. |
yashk2810
approved these changes
Sep 9, 2022
google-ml-butler
bot
added
kokoro:force-run
pull ready
|
Sounds good, thanks! |
As part of this change, I created a helper function so that the logic of type checking is in a single location. Eventually we can replace this helper function with appropriate isinstance() checks using the APIs described in jax-ml#11859.
jakevdp
force-pushed
the
fix-lax-array
branch
from
ba4bb43 to
07f55b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this change, I created a helper function so that the logic of type checking is in a single location. Eventually we can replace this helper function with appropriate isinstance() checks using the APIs described in #11859.
This work is part of #12016 & #12049.