Conversation
The fallback's git checkout restore now captures stderr, checks its return code and warns on failure (instead of silently leaving the lockfile dirty), and catches FileNotFoundError if git is absent. Adds a test for the npm ci failure -> npm install -> restore -> build path. Even if the restore fails, apply_update restores the lockfile before every pull, so it stays double-covered.
Under WSL the Linux VM is capped at 50% of the Windows host by default (8GB on a 16GB machine), so /proc/meminfo reports 8GB and users think taOS is limiting them. Add _detect_wsl (WSL_DISTRO_NAME/WSL_INTEROP env or /proc/version 'microsoft') and a wsl flag + mem_note advisory on HardwareProfile pointing to .wslconfig memory= + wsl --shutdown. ram_mb is left unchanged (it is genuinely what the VM has); this only contextualizes it. Exposed via the hardware profile API for the UI to surface.
fix: harden npm-ci fallback (gitar #1197) + detect WSL memory cap
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
👋 Thanks for the PR! This one targets See CONTRIBUTING.md for the branch model. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughTwo independent improvements: ChangesWSL Detection in HardwareProfile
Desktop Rebuild Fallback Hardening
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Promotes #1199 (gitar fallback hardening + WSL memory detection). Constituent PRs were CI-gated into dev. Jay-authorized.
Summary by CodeRabbit
Bug Fixes
New Features
Tests