Skip to content

Promote dev to master: WSL/minimal-box install robustness (#1216)#1217

Merged
jaylfc merged 4 commits into
masterfrom
dev
Jun 20, 2026
Merged

Promote dev to master: WSL/minimal-box install robustness (#1216)#1217
jaylfc merged 4 commits into
masterfrom
dev

Conversation

@jaylfc

@jaylfc jaylfc commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Fast-track promotion so the public installer (fetched from master) carries the WSL install fix.

Brings only #1216: the no-systemd controller fallback + don't-abort-on-optional-components + drop-to-service-user-without-sudo. Fixes the reported WSL install that aborted at docker/incus coexistence and left no UI. CI green on dev (test 3.12/3.13, spa-build, lint, CodeRabbit); gitar findings folded.

jaylfc added 4 commits June 20, 2026 16:31
…troller (#117)

On Linux the installer always used systemctl; on a box where systemd is not the
init (e.g. WSL without systemd) 'systemctl enable --now tinyagentos' just fails
and the UI is never reachable -- exactly the dead-end a WSL user hits. Detect
that systemd is not the running init and fall back to launching the controller
as a background process (mirroring the unit's user/env), leave a taos-run.sh
re-launch helper, verify it answers on the port, and explain how to enable
systemd (WSL: systemd=true in /etc/wsl.conf) for a managed service. Normal
systemd hosts are unchanged.
Container/Docker and LiteLLM-postgres setup are optional for the core
controller. On hosts where they cannot complete (WSL without systemd,
minimal VMs, incus/docker iptables ops failing under set -e) the script
was dying silently before the SPA bundle and controller service were
installed, leaving the user with no UI.

Guard the three optional-component entry points with || warn so they
warn and continue instead of taking down the whole install. The core
controller now completes on WSL even when containers/docker/postgres
cannot run.
The no-systemd nohup fallback dropped privileges from root via
'sudo -u taos', but minimal containers -- one of the two targeted
environments -- often run as root with no sudo binary, so the
controller never started and the box was left with the dead UI this
fallback exists to prevent.

- install-time launch: prefer runuser, then sudo, then su (runuser/su
  are util-linux, present on minimal boxes).
- generated taos-run.sh helper: when re-run as root (the documented
  post-reboot path), re-drop to the service user via the same ladder so
  data/ stays owned by taos instead of accumulating root-owned files
  that break a later taos run.

Addresses both gitar findings on #1216 (Edge Case + Quality).
install: robust WSL/minimal-box install (no-systemd fallback + don't abort on optional components) (#117)
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@jaylfc jaylfc merged commit 4c9778d into master Jun 20, 2026
12 of 14 checks passed
@github-actions

Copy link
Copy Markdown

👋 Thanks for the PR! This one targets master, which is our
stable branch (it's what live installs track). Please retarget it to
dev — click Edit next to the PR title and change the base
branch dropdown from master to dev. Your commits and any review
carry over, nothing is lost.

See CONTRIBUTING.md for the branch model.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jaylfc, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 11 minutes and 9 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0933431b-e9c5-42e2-8de6-b8c22cac4f46

📥 Commits

Reviewing files that changed from the base of the PR and between bee4341 and 99fde71.

📒 Files selected for processing (1)
  • scripts/install-server.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant