Skip to content

refactor(taosctl): dashboard uses shared positive_int validator#1403

Merged
jaylfc merged 1 commit into
devfrom
refactor/dashboard-shared-argtypes
Jun 23, 2026
Merged

refactor(taosctl): dashboard uses shared positive_int validator#1403
jaylfc merged 1 commit into
devfrom
refactor/dashboard-shared-argtypes

Conversation

@jaylfc

@jaylfc jaylfc commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Follow-up to #1401. The dashboard group carried an inline _positive_int; now that the shared tinyagentos/cli/taosctl/argtypes.positive_int is on dev, this removes the duplicate and imports the shared helper. Behaviour is unchanged (activity --limit still rejects non-positive values at parse time). 22 tests pass (dashboard + argtypes + route-coverage gate).

Replace the dashboard group's inline _positive_int with the shared
tinyagentos/cli/taosctl/argtypes.positive_int (landed in #1401), removing the
duplicate now that both are on dev. Behaviour unchanged; --limit still rejects
non-positive values at parse time.
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@jaylfc jaylfc enabled auto-merge (squash) June 23, 2026 13:20
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jaylfc, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 minute and 22 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 05f55a69-607e-47eb-acda-c3526335fc02

📥 Commits

Reviewing files that changed from the base of the PR and between f61a965 and 74a7a1d.

📒 Files selected for processing (1)
  • tinyagentos/cli/taosctl/commands/dashboard.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/dashboard-shared-argtypes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

Note

Your trial team has used its Gitar budget, so automatic reviews are paused. Upgrade now to unlock full capacity. Comment "Gitar review" to trigger a review manually.
Learn more about usage limits

Code Review ✅ Approved

Refactors dashboard argument parsing to utilize the shared positive_int validator, eliminating code duplication while maintaining strict input validation. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Important

Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@jaylfc jaylfc merged commit 98ed0e2 into dev Jun 23, 2026
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in TinyAgentOS Roadmap Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant