fold gitar Edge-Cases on merged app-perms PRs (#1404, #1405)#1408
Conversation
#1404 (broker best-effort): the app_grants ledger lookup in the userspace broker route was unguarded, so an uninitialised store or a query error turned a previously-working broker call into a 500, contradicting the best-effort comment. Wrap it in try/except that logs and falls back to the per-app granted set. #1405 (network origin validation): the grant API accepted any network: prefix, including an empty or malformed origin, so a typo'd origin produced a ledger row. Centralise the strict origin pattern as NET_ORIGIN_RE in capabilities.py (single source of truth, the package parser now reuses it) plus a is_valid_network_grant helper, and reject malformed network grants at the API with a 400. Tests: broker falls back instead of 500 on a raising ledger; malformed network origins rejected; package parser still validates origins via the shared pattern. 203 passed across the userspace + app-perms suites.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
More reviews will be available in 24 minutes and 58 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Your trial team has used its Gitar budget, so automatic reviews are paused. Upgrade now to unlock full capacity. Comment "Gitar review" to trigger a review manually. Code Review ✅ ApprovedAdds exception handling to the broker's capability lookup and enforces strict network origin validation via a centralized regex. Both issues are resolved, preventing 500 errors and meaningless ledger entries. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Important Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Two gitar Edge-Case findings on the merged app-permissions PRs, fixed forward.
#1404 broker best-effort
The decision-24 ledger merge in the userspace broker route called
granted_capabilitiesunguarded. An uninitialised store (raises RuntimeError) or a query error would 500 the broker, contradicting the best-effort comment. Now wrapped in try/except that logs and falls back to the per-app granted set.#1405 network origin validation
The grant API accepted any
network:prefix, includingnetwork:(empty) or a malformed origin, recording a meaningless ledger row. Centralised the strict origin pattern asNET_ORIGIN_REincapabilities.py(single source of truth, reused by the package parser) plus anis_valid_network_granthelper, and the grant API now rejects malformed network grants with a 400.Tests
New: broker falls back instead of 500 when the ledger raises; malformed network origins rejected (parametrized); package origin test uses the shared pattern. 203 passed across the userspace + app-perms suites.