chore(canvas): remove the superseded Konva render layer#1410
Conversation
The Konva board (KonvaBoard.tsx + element-to-konva.ts) was built against an earlier engine decision and was never wired into CanvasView (the live renderer is the tldraw CanvasBoard). The Excalidraw migration replaces it, and the element-to-excalidraw mapping has landed, so the Konva layer is dead code. Remove KonvaBoard.tsx, element-to-konva.ts, their two tests, and the konva + react-konva dependencies (now unused). Drops two runtime deps from the desktop bundle. tldraw stays the live renderer until the Excalidraw swap slice; this is only the Konva-removal half of the cleanup.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (5)
📝 WalkthroughWalkthroughRemoves the Konva-based canvas renderer from the ProjectsApp: deletes ChangesKonva Canvas Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Verified the PR claims in the description:
Files Reviewed (7 files)
Reviewed by minimax-m3 · Input: 52.7K · Output: 1.7K · Cached: 137.6K |
|
Note Your trial team has used its Gitar budget, so automatic reviews are paused. Upgrade now to unlock full capacity. Comment "Gitar review" to trigger a review manually. Code Review ✅ ApprovedRemoves the superseded Konva board implementation and its associated dependencies now that the Excalidraw migration is underway. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Important Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
The Konva board (
KonvaBoard.tsx+element-to-konva.ts) was built against an earlier engine decision (the canvas-konva-migration spec, superseded by the Excalidraw decision) and was never wired intoCanvasView(which renders the tldrawCanvasBoard). The Excalidraw migration replaces it and theelement-to-excalidrawmapping has landed (#1407), so the Konva layer is dead code.Removed
KonvaBoard.tsx,element-to-konva.tsand their two testskonva+react-konvadependencies (only KonvaBoard imported them)Verified: nothing else imports KonvaBoard/element-to-konva or konva/react-konva;
tsc -bclean; ProjectsApp tests 49 pass. tldraw stays the live renderer until the Excalidraw swap slice; this is only the Konva-removal half of the slice-6 cleanup (tldraw removal follows the swap).Summary by CodeRabbit
Refactor
Tests