Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
👋 Thanks for the PR! This one targets See CONTRIBUTING.md for the branch model. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single word change in ChangesREADME Creative Studios Status
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
| onOpen: (appId: string) => void; | ||
| onInstall: (appId: string) => Promise<void>; | ||
| }) { | ||
| const isInstalled = installed.has(studio.id); |
There was a problem hiding this comment.
💡 Quality: StudioHero uses studio.id directly instead of studioAppId mapping
StudioHero references the raw studio.id for the installed check (installed.has(studio.id)), install (onInstall(studio.id)), and open (onOpen(studio.id)), whereas StudioCard consistently goes through studioAppId(studio.id) (which maps images-studio -> images). This works today only because the hero is hard-coded to coding-studio (line 500), whose catalog id equals its registry/allowlist id. If the hero is ever pointed at a studio whose catalog id differs from its app id (e.g. images-studio), the install POST would 404 against the allowlist and getApp would fail to open the window. Route the hero through studioAppId to match the card and remove the latent inconsistency.
Use the same studioAppId mapping the grid card uses so the hero is robust to any featured studio.:
// in StudioHero
const appId = studioAppId(studio.id);
const isInstalled = installed.has(appId);
// ...
await onInstall(appId);
// ...
onClick={isInstalled ? () => onOpen(appId) : handleGet}
- Apply fix
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎
| OPTIONAL_FRONTEND_APPS = { | ||
| "reddit", "youtube-library", "github-browser", "x-monitor", | ||
| # Creative Studios install the same way: a frontend-only optional app whose | ||
| # install row just flips the launcher visibility, no service spawned. | ||
| "coding-studio", "design-studio", "music-studio", "app-studio", "office-suite", | ||
| } |
There was a problem hiding this comment.
💡 Quality: PR labeled docs-only but adds feature code, install wiring, backend allowlist
The PR title ("docs: studios availability wording (in beta)") and description ("Docs-only.") describe a wording change, but this commit registers five new studio apps, wires Store install/launch behaviour, and extends the backend OPTIONAL_FRONTEND_APPS allowlist. The change itself looks correct, but the mismatched docs: framing will mislead release notes (CodeRabbit summary already only mentions documentation) and anyone auditing the changelog for new install-state surface area. Consider re-labeling as feat: and noting the backend allowlist expansion so the new installable endpoints are reviewed/tracked as functionality, not docs.
Was this helpful? React with 👍 / 👎
|
Note Your trial team has used its Gitar budget, so automatic reviews are paused. Upgrade now to unlock full capacity. Comment "Gitar review" to trigger a review manually. Code Review 👍 Approved with suggestions 0 resolved / 2 findingsIntegrates five optional studio applications into the Store catalog and app registry. Refactor the PR title and description to accurately reflect the functional changes, and update StudioHero to utilize the studioAppId mapping instead of raw studio IDs. 💡 Quality: StudioHero uses studio.id directly instead of studioAppId mapping📄 desktop/src/apps/StoreApp/StudiosView.tsx:235 📄 desktop/src/apps/StoreApp/StudiosView.tsx:240 📄 desktop/src/apps/StoreApp/StudiosView.tsx:283 📄 desktop/src/apps/StoreApp/StudiosView.tsx:500
Use the same studioAppId mapping the grid card uses so the hero is robust to any featured studio.💡 Quality: PR labeled docs-only but adds feature code, install wiring, backend allowlist📄 tinyagentos/routes/apps.py:29-34 📄 desktop/src/apps/StoreApp/StudiosView.tsx:512-521 The PR title ("docs: studios availability wording (in beta)") and description ("Docs-only.") describe a wording change, but this commit registers five new studio apps, wires Store install/launch behaviour, and extends the backend 🤖 Prompt for agentsOptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
1 participant
Reword the live studios from 'ship today' to 'in beta', matching the product's beta status. Docs-only.
Summary by CodeRabbit
Summary by Gitar
STATUS.mdto reflect latest progress on Creative Studios and deployment status on the Pi.Coding,Design,Music,App,Office) with the Store catalog and install flow.tinyagentos/routes/apps.pyand updatedapp-registry.ts.StudiosViewwith featured hero card, studio grid, community studio section, and shareable layout chips.BuildView,DesignView,StudioView) for the new studios.CodingStudioApp,AppStudioApp, andStudiosViewto verify navigation and interaction states.This will update automatically on new commits.