Prevent exception when query object has empty WHERE clause #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't attempt to destructure a return value which could be None.
…hod-187082048 [#187082048] Fix model manager method
nikolas
reviewed
Jun 17, 2024
| @@ -177,10 +178,11 @@ def usage_for_queryset(self, queryset, counts=False, min_count=None): | |||
| Passing a value for ``min_count`` implies ``counts=True``. | |||
| """ | |||
| compiler = queryset.query.get_compiler(using=queryset.db) | |||
| where, params = compiler.compile(queryset.query.where) | |||
| params = None | |||
There was a problem hiding this comment.
I think this line can be removed - does params really need to be set to None here?
There was a problem hiding this comment.
params needs to be at least declared here, otherwise it will not be available in the return statement of this function. Results in local variable 'params' referenced before assignment
|
I ran into a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
I discovered your fork of the
django-taggingproject from the discussion on this PR. I'm trying to use this in a project which runs on Django 4, and made some small fixes which I've included in this PR.This PR modifies the
get_usage_for_queryset()method to handle empty WHERE-clauses in the passed-in query.Let me know if you'd like any additional info!