Add authetication for fetch stats from /admin/status-json.xls#7
Open
kaiyga wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was added authetication merhod for fetch statistic.
Its should up level of security for multy-mount instances
(We have a lot of mounts in one instance and it should be secure)
This Merge request contain two method of authetication in Icecast Instance
CLI Arguments (and env for password)
Recomended use env variables for password
One source of trust for side-cart cases
Icecast config for side-cart with Icecast Instance.
It important for us because we dynamic update config of icecast and can forget update authetication data for icecast-exporter.
With one source we can do it dynamicly
Basic functionality implemented. I havent more time for deep testing but i think it should work.