Skip to content

Use CMake find_package and official targets instead of libray names #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uilianries wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use CMake find_package and official targets instead of libray names #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68dec18
Use Cmake targets
uilianries Dec 2, 2025
2ca1eaf
Merge branch 'main' into cmake/find-targets
jbaldwin Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,13 @@ option(LIFT_BUILD_TESTS "Build the tests. Default=ON" ON)
option(LIFT_CODE_COVERAGE "Enable code coverage, tests must also be enabled. Default=OFF" OFF)
option(LIFT_RUN_GITCONFIG "Set the githooks directory to auto format code and update the readme, Default=OFF." OFF)

if(NOT DEFINED LIFT_USER_LINK_LIBRARIES)
set(
LIFT_USER_LINK_LIBRARIES
curl z uv pthread dl stdc++fs
CACHE STRING
"Override ${PROJECT_NAME} required link libraries, defaults to [curl z uv pthread dl stdc++fs]. If changed all defaults must be accounted for manually."
)
endif()
find_package(CURL REQUIRED)
find_package(libuv REQUIRED)
find_package(Threads REQUIRED)

message("${PROJECT_NAME} LIFT_BUILD_EXAMPLES = ${LIFT_BUILD_EXAMPLES}")
message("${PROJECT_NAME} LIFT_BUILD_TESTS = ${LIFT_BUILD_TESTS}")
message("${PROJECT_NAME} LIFT_CODE_COVERAGE = ${LIFT_CODE_COVERAGE}")
message("${PROJECT_NAME} LIFT_USER_LINK_LIBRARIES = ${LIFT_USER_LINK_LIBRARIES}")
message("${PROJECT_NAME} LIFT_RUN_GITCONFIG = ${LIFT_RUN_GITCONFIG}")

if (LIFT_RUN_GITCONFIG)
Expand All @@ -37,6 +31,9 @@ if(MSVC)
add_definitions(-DNOMINMAX)
endif()

# LibUV >=1.45 introduced an imported target 'libuv::uv'
set(LIBUV_TARGET $<IF:$<TARGET_EXISTS:libuv::uv>,libuv::uv,uv>)

set(LIBLIFTHTTP_SOURCE_FILES
inc/lift/impl/copy_util.hpp
inc/lift/impl/pragma.hpp
Expand Down Expand Up @@ -64,8 +61,7 @@ target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_17)

target_include_directories(${PROJECT_NAME} SYSTEM PUBLIC ${LIFT_CURL_INCLUDE})
target_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/inc)

target_link_libraries(${PROJECT_NAME} PUBLIC ${LIFT_USER_LINK_LIBRARIES})
target_link_libraries(${PROJECT_NAME} PUBLIC CURL::libcurl ${LIBUV_TARGET} Threads::Threads)

if(LIFT_CODE_COVERAGE)
if(${CMAKE_CXX_COMPILER_ID} MATCHES "GNU")
Expand Down
Loading