-
Notifications
You must be signed in to change notification settings - Fork 9
Junit 5 migration #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Junit 5 migration #103
Conversation
| * <p> | ||
| * Adjusted from the HAL testsuite (<a href="https://github.com/hal/testsuite">...</a>). | ||
| */ | ||
| public class ArquillianParametrized extends ParentRunner<Arquillian> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomjenkinson lra-test-arquillian-extension is an artifact we release and this class is not under test folder.
Should I go through the process of deprecation of this class before removing it?
Please consider this is strictly related to Junit4 Runner (org.junit.runners.ParentRunner) not used in junit5 anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, you should. If you as the project lead decide not to do that then I suppose you would communicate it and the reason not to.
BTW: It might be worth moving everything that is internal (but published) into an "/internal/" package. Why do we even publish the artifact? Is it for TCK testing? If so, Does TCK testing use this class directly? If so at the least it needs to be coordinated with that project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is for tck but I don't see any usage of this class.
I will deprecate this class then. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a deprecation PR here, could you please have a look @tomjenkinson ?
e2324b3 to
285612b
Compare
|
Putting the Hold label as this PR is for the next minor version of lra. |
addresses #101
rewrite-maven-plugin (https://github.com/openrewrite/rewrite-maven-plugin) was used in commit db004f1 to address most of the changes needed.
Extra work was needed and done in this commit e2324b3
Some classes were deleted as junit5 doesn't support Runners and Rules of Junit4.