Skip to content

Conversation

@marcosgopen
Copy link
Member

@marcosgopen marcosgopen commented Sep 24, 2025

addresses #101

rewrite-maven-plugin (https://github.com/openrewrite/rewrite-maven-plugin) was used in commit db004f1 to address most of the changes needed.

<plugin>
    <groupId>org.openrewrite.maven</groupId>
    <artifactId>rewrite-maven-plugin</artifactId>
    <version>6.11.0</version>
    <configuration>
        <activeRecipes>
            <recipe>org.openrewrite.java.testing.junit5.JUnit4to5Migration</recipe>
            <recipe>org.openrewrite.java.testing.junit5.CleanupAssertions</recipe>
            <recipe>org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipe</recipe>
            <recipe>org.openrewrite.java.testing.junit5.AddParameterizedTestAnnotation</recipe>
            <recipe>org.openrewrite.java.testing.junit5.RemoveTryCatchFailBlocks</recipe>
            <recipe>org.openrewrite.java.testing.junit5.LifecycleNonPrivate</recipe>
            <recipe>org.openrewrite.java.testing.junit5.AssertThrowsOnLastStatement</recipe>
            <recipe>org.openrewrite.java.testing.arquillian.ArquillianJUnit4ToArquillianJUnit5</recipe>
        </activeRecipes>
    </configuration>
    <dependencies>
        <dependency>
            <groupId>org.openrewrite.recipe</groupId>
            <artifactId>rewrite-testing-frameworks</artifactId>
            <version>3.10.0</version>
        </dependency>
    </dependencies>
</plugin>

Extra work was needed and done in this commit e2324b3

Some classes were deleted as junit5 doesn't support Runners and Rules of Junit4.

* <p>
* Adjusted from the HAL testsuite (<a href="https://github.com/hal/testsuite">...</a>).
*/
public class ArquillianParametrized extends ParentRunner<Arquillian> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomjenkinson lra-test-arquillian-extension is an artifact we release and this class is not under test folder.
Should I go through the process of deprecation of this class before removing it?
Please consider this is strictly related to Junit4 Runner (org.junit.runners.ParentRunner) not used in junit5 anymore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, you should. If you as the project lead decide not to do that then I suppose you would communicate it and the reason not to.

BTW: It might be worth moving everything that is internal (but published) into an "/internal/" package. Why do we even publish the artifact? Is it for TCK testing? If so, Does TCK testing use this class directly? If so at the least it needs to be coordinated with that project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is for tck but I don't see any usage of this class.
I will deprecate this class then. Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a deprecation PR here, could you please have a look @tomjenkinson ?

@marcosgopen
Copy link
Member Author

Putting the Hold label as this PR is for the next minor version of lra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants