[JBTM-4014] restore longToHexString method

[marcosgopen]

#2427 leftover

@franz1981 there is still a unit test for longToHexString method. I am restoring it because the removal caused a compilation error in QA axes.
In case we would like to remove it we might need to deprecate it first.

CORE !AS_TESTS !RTS !JACOCO !XTS QA_JTA QA_JTS_OPENJDKORB !PERFORMANCE !DB_TESTS

[jbosstm-bot]

CORE profile tests failed (https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/57/): Narayana rebase on main failed. Please rebase it manually

[jbosstm-bot]

QA_JTA profile tests failed (https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK21,label=jnlp-agent/57/): Narayana rebase on main failed. Please rebase it manually

[jbosstm-bot]

QA_JTS_OPENJDKORB profile tests failed (https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=openJDK21,label=jnlp-agent/57/): Narayana rebase on main failed. Please rebase it manually

[jbosstm-bot]

QA_JTS_OPENJDKORB profile tests failed (https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=openJDK17,label=jnlp-agent/57/): Narayana rebase on main failed. Please rebase it manually

[jbosstm-bot]

Started testing this pull request with CORE profile: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/58/

[jbosstm-bot]

Started testing this pull request with QA_JTA profile: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK21,label=jnlp-agent/58/

[jbosstm-bot]

Started testing this pull request with QA_JTS_OPENJDKORB profile: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=openJDK21,label=jnlp-agent/58/

[jbosstm-bot]

Started testing this pull request with CORE profile: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/59/

[jbosstm-bot]

CORE profile tests passed - Job complete https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/58/

[jbosstm-bot]

Started testing this pull request with CORE profile: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK21,label=jnlp-agent/59/

[jbosstm-bot]

CORE profile tests passed - Job complete https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/59/

[jbosstm-bot]

QA_JTA profile tests passed - Job complete https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK21,label=jnlp-agent/58/

[jbosstm-bot]

CORE profile tests passed - Job complete https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK21,label=jnlp-agent/59/

[jbosstm-bot]

QA_JTS_OPENJDKORB profile tests passed - Job complete https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=openJDK21,label=jnlp-agent/58/

[jmfinelli]

Do you think it is worth adding @Deprecated to the methods you intend to deprecate?

[marcosgopen]

Do you think it is worth adding @Deprecated to the methods you intend to deprecate?

I do not know @jmfinelli . What I can see is that that is a public utility method, static, it is not in an internal class and that is part of a released artifact, hence my concern. However I am not sure, so in this PR I only restore the method needed for the QA test asking for advice.

[jmfinelli]

I think I miss which QA test is failing. Could you please share which one it is?

I suppose adding '@deprecated' to the method(s) you intend to deprecate would help clarify your plan. IOW, in case we add that annotation, the PR will be easier to review (IMO)

[marcosgopen]

Sorry Manuel, actually it is a compilation error:

    [javac] Compiling 1449 source files to /home/jenkins/workspace/narayana/PROFILE/QA_JTA/jdk/openJDK17/label/jnlp-agent/qa/tests/build/classes
    [javac] /home/jenkins/workspace/narayana/PROFILE/QA_JTA/jdk/openJDK17/label/jnlp-agent/qa/tests/src/org/jboss/jbossts/qa/ArjunaCore/Common/UtilityTest.java:128: error: cannot find symbol
    [javac] 		hexReturnValue = Utility.longToHexString(passedValue);
    [javac] 		                        ^
    [javac]   symbol:   method longToHexString(long)
    [javac]   location: class Utility
    [javac] /home/jenkins/workspace/narayana/PROFILE/QA_JTA/jdk/openJDK17/label/jnlp-agent/qa/tests/src/org/jboss/jbossts/qa/CrashRecovery09Impls/

See failure here: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/narayana/PROFILE=QA_JTA,jdk=openJDK17,label=jnlp-agent/404/consoleFull

[marcosgopen]

I think I miss which QA test is failing. Could you please share which one it is?

I suppose adding '@deprecated' to the method(s) you intend to deprecate would help clarify your plan. IOW, in case we add that annotation, the PR will be easier to review (IMO)

Sorry @jmfinelli , the description was not clear. I have updated it. My plan is to restore the method to fix the compilation error.