Add jonesforth as a git submodule#25
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces a vendored copy of the jonesforth.f file with a git submodule reference, improving dependency management by sourcing the file from an external repository instead of maintaining a local copy.
Key changes:
- Added jonesforth as a git submodule pointing to the nornagon/jonesforth repository
- Updated the build process to copy jonesforth.f from the submodule instead of the local assets directory
- Removed the locally maintained jonesforth.f file (1,788 lines)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| jonesforth | Added as a new git submodule pointing to commit d97a25bb0b06fb58da1975eac291f45618fd2ada |
| assets/jonesforth.f | Removed the entire locally maintained copy of the jonesforth.f file |
| assets/Makefile | Updated build rule to copy jonesforth.f from the submodule directory (../jonesforth/%.F) and added jonesforth.f as a build target |
| .gitmodules | Registered the jonesforth submodule configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.