Breaking Change - All functions that took a Peer now take a *Session #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows us to generate session-specific ids
Collaborator
Author
|
This is the fix for #85 |
- fixes a problem when running with AutobahnPython and twisted
- prevent data race; maps aren't safe for concurrent use
Collaborator
|
IMO, it does makes sense to make this API change. I also found this change is needed in order to add smarter external The |
- fixes problems with multiple subscribers to the same topic
- no guarantee they still work, but this makes it easier to run tests
- single rw lock to make eliminate races, could definitely use some performance tuning/refactoring
- it seems like this was blocking when the socket was already closed, which caused some stability issues over time as goroutines built up
- I noticed a that defaultBroker.Subscribe could block, and the only way that could happen is if the Send function in either Unsubscribe (unlikely) or Publish (very likely) blocked - I think there's still a larger problem with transports blocking on the Send, but this should at least allow messages to go through if that happens
Also added a write timeout.
- fixes memory leak
This should probably be easier to set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically rewrote
dealer.goon a rereading of the spec. I was getting errors with AutobahnPython saying that the INVOCATION ID was reused (was causing somewhat random crashes). We were usingNewID()to generate this, which generates the ID randomly, so I switched it to a session-specific, incrementing ID as per the spec. I also simplified some of the internal data structures.Moving the *Session into the Dealer is a breaking change and was needed to generate session-specific identifiers for the fix. We talked about this previously, and we had decided not to do it because there wasn't a reason to complicate matters, but I think this is now necessary to be spec compliant.
If this looks good to you, I can check if our ids are correct elsewhere.