Improve webhook reviewer type definitions #3803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract ReviewerState type to avoid duplication between Webhooks and MergeRequests - Add WebhookReviewerSchema with proper state and re_requested fields - Add email field to WebhookUserSchema based on actual webhook payloads - Add missing 'unapproved' state found in production webhooks - Update changes.reviewers to use WebhookReviewerSchema References: - https://docs.gitlab.com/user/project/integrations/webhook_events/#reviewer-state-tracking - https://docs.gitlab.com/user/project/integrations/webhook_events/#re-request-review-events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReviewerStatetype to avoid duplication betweenWebhooksandMergeRequestsWebhookReviewerSchemawith properstateandre_requestedfieldsemailfield toWebhookUserSchemabased on actual webhook payloads'unapproved'state found in production webhookschanges.reviewersto useWebhookReviewerSchemaReferences: