fix(rest): correct exponential backoff delay from seconds to milliseconds #3806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The delay calculation
2 ** i * 0.25produces values that are effectively sub-millisecond (0.25ms, 0.5ms, 1ms...) when passed tosetTimeout, which expects milliseconds. This causes all 10 retries to complete in ~256ms instead of the intended ~256 seconds of exponential backoff.Changes
await delay(2 ** i * 0.25)toawait delay(2 ** i * 250)inpackages/rest/src/Requester.tsNew Delay Schedule
Testing
jest.useFakeTimers()andjest.runAllTimersAsync()to avoid actual waitingFixes #3805