Skip to content
This repository was archived by the owner on Jan 7, 2023. It is now read-only.

A bug about exifRotation #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A bug about exifRotation #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8acc31
when we set fixed aspect ratio ,if the crop are not square,and the
KillerMeng Jul 23, 2015
66c5f83
1)if the picture need not to be scale, they also neet to be rotate to 0
KillerMeng Jul 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/src/main/java/com/soundcloud/android/crop/CropImageActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,14 @@ private Bitmap decodeRegionCrop(Rect rect, int outWidth, int outHeight) {
RectF adjusted = new RectF();
matrix.mapRect(adjusted, new RectF(rect));

//if the cutting box are rectangle( outWidth != outHeight ),and the exifRotation is 90 or 270,
//the outWidth and outHeight showld be interchanged
if (exifRotation==90||exifRotation==270){
int temp=outWidth;
outWidth=outHeight;
outHeight=temp;
}

// Adjust to account for origin at 0,0
adjusted.offset(adjusted.left < 0 ? width : 0, adjusted.top < 0 ? height : 0);
rect = new Rect((int) adjusted.left, (int) adjusted.top, (int) adjusted.right, (int) adjusted.bottom);
Expand All @@ -335,6 +343,14 @@ private Bitmap decodeRegionCrop(Rect rect, int outWidth, int outHeight) {
if (rect.width() > outWidth || rect.height() > outHeight) {
Matrix matrix = new Matrix();
matrix.postScale((float) outWidth / rect.width(), (float) outHeight / rect.height());

//if the picture's exifRotation !=0 ,they should be rotate to 0 degrees
matrix.postRotate(exifRotation);
croppedImage = Bitmap.createBitmap(croppedImage, 0, 0, croppedImage.getWidth(), croppedImage.getHeight(), matrix, true);
}else{
//if the picture need not to be scale, they also neet to be rotate to 0 degrees
Matrix matrix = new Matrix();
matrix.postRotate(exifRotation);
croppedImage = Bitmap.createBitmap(croppedImage, 0, 0, croppedImage.getWidth(), croppedImage.getHeight(), matrix, true);
}
} catch (IllegalArgumentException e) {
Expand Down