Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom remote script support for Linux remotes #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StarLederer
Copy link

This PR makes it so that server setup scans the remote for known remote installer locations before attempting to use built in scripts.

This allows users to:

@StarLederer
Copy link
Author

If this is welcome, we possibly need to document how to write custom scripts or make the default one work the same as custom

@jeanp413
Copy link
Owner

jeanp413 commented Feb 1, 2024

Thanks for the PR @StarLederer 🙏 , can we add a extension setting like remote.SSH.customServerInstallScriptPath and use that instead of harcoding it, also a new command like Customize Server Installation Script and then open a vscode document and initialize it with the default script content that the user can edit and save.

@StarLederer
Copy link
Author

StarLederer commented Feb 11, 2024

I figured using conventional paths would be best for users so they don't have to think how each remote is configured, just whether it explicitly supports open-remote-ssh or not. It is possibly a good idea allow users to override this per host so that their host providers are able to escape the conventional structure if they really need to but I imagine this being more the exception than the rule.

As per hard-coded paths vs configurable defaults, I see how in the future the MS extension might also adopt this and use different paths than us but I would add an option to change the default paths only when that happens. I think if users identify missing but expected paths, like something for windows hosts, it is better to add these paths to the extension to help users find the conventional way to organize this and use this extension seamlessly across many remotes. Let me know if you agree.

I really like your Customize Server Installation Script idea though, it will give users an example that they can start messing with right away and make it very easy to find where to put the config avoiding the need for extra documentation, but I have no idea how to implement this. VS Code extensions are far from my expertise. Perhaps that could be a separate PR that we collaborate on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants