AOT compilation compatibility fix #3
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the speed dial and datatable components to drop the dependency on forwardRef, which had been breaking AOT compilation in my project.
(Note: my project doesn't use the datatable, just the speed dial, so my testing only covered the speed dial. I don't see why this change would cause a functionality regression in the data table when the speed dial continued to work as intended, but probably worth testing anyway before you merge this. It's also entirely possible that other AOT-breaking issues exist in the datatable component, as I've only confirmed that the speed dial AOT compiles successfully.)
Also, thanks a lot for taking the time to make this! smd-fab-speed-dial filled in the last remaining gap before I could finally start porting my project from a custom UpgradeModule-based Material1 wrapper to Material2.