Remove unneeded peer dependency on ember-source

[NullVoxPopuli]

embroider, auto-import, and ember-cli before them handled virtual deps without a package.json entry.

package.json entries win over virtual deps, so we don't want to declare ember-source or @glimmer/tracking as peers.

Related:

• Remove unneeded peer declarations ember-polyfills/ember-functions-as-helper-polyfill#151
• Remove unneeded peer dependency on ember-source #312
• Remove unneeded peers jmurphyau/ember-truth-helpers#211
• Remove unneeded peers ember-modifier/ember-modifier#949
• Remove unneeded peers tracked-tools/tracked-toolbox#211
• Remove unneeded peers emberjs/ember-test-helpers#1543
• Remove ember-source virtualDeps from peerDeps NullVoxPopuli/ember-resources#1189
• Remove unneeded peers NullVoxPopuli/ember-modify-based-class-resource#20
• Remove unneeded peerDependencies (provided by ember-source virtualDeps) universal-ember/kolay#187
• Remove unneeded peers universal-ember/reactiveweb#139
• Remove unneeded peers universal-ember/ember-primitives#471
• Remove unneeded peer universal-ember/docs-support#77

[jelhan]

Ember CLI addon blueprints add a peer dependency on ember-source: https://github.com/ember-cli/ember-addon-output/blob/c34e1239793a3c5faafbdffccf898d8bdf38ff73/package.json#L81-L83 Is there a RFC pending for implementation that this should be changed?

[NullVoxPopuli]

No RFC needed, see: https://discord.com/channels/480462759797063690/568935504288940056/1370714948447113226

Changes to these sorts of things in the blueprints are to try to reduce problems for consumers, and are less so in need of opinions from the RFR process <3. I understand it is surprising tho. It was surprising to me when i found out we shouldn't be doing this as well!

• ember-source: removed because the embroider / auto-import know what we intend - it's not bad to have if someone manages their dep graph correctly, which is easier with pnpm, but not everyone gets it right, and folks have a hard time tracking down errors
• @glimmer/tracking removed because it's a real package, but one we don't want to use. This comes up in embroider/vite where the presence of real packages always takes precedence over virtual packages. This is actually problematic because it can break reactivity in subtle ways, even if a dep graph is correct - allowing duplicates of dependencies, which for the glimmer internals, we don't want.

Hope this helps!

[NullVoxPopuli]

addon blueprints add a peer dependency on ember-source

I removed it from the v2 addon blueprint yesterday.
And removed @glimmer/tracking from the v2 app blueprint a couple days prior

[NullVoxPopuli]

Opened a PR here for the v1

ember-cli/ember-cli#10697

[jelhan]

Thanks a lot for sharing all those details.

I tend to wait merging this one until the change got merged into the standard blueprints. I have only very limited time for maintaining this addon and others. Therefore I try staying as close as possible to the defaults to ease maintenance.

[NullVoxPopuli]

The maintained addon blueprints already do this:

• old: https://github.com/embroider-build/addon-blueprint/blob/main/files/__addonLocation__/package.json
• proposed new default: https://github.com/ember-cli/ember-addon-blueprint/blob/main/files/package.json