Accept -1 as HEAD revision and canonicalize paths/URLs#205
Merged
Conversation
Owner
jelmer
commented
Mar 17, 2026
jelmer
commented
- Add to_revnum_or_head() that maps negative revision numbers to Revnum::invalid() (SVN_INVALID_REVNUM), which SVN interprets as HEAD. Replace all to_revnum().ok_or_else() patterns with this function.
- Add to_relpath() helper for proper SVN relpath canonicalization. Replace ad-hoc trim_start_matches('/') with RelPath::canonicalize().
- Canonicalize URLs in RemoteAccess.init() and reparent() to prevent assertion failures in libsvn.
- Canonicalize URLs in wc.ensure_adm().
- Add to_revnum_or_head() that maps negative revision numbers to
Revnum::invalid() (SVN_INVALID_REVNUM), which SVN interprets as HEAD.
Replace all to_revnum().ok_or_else() patterns with this function.
- Add to_relpath() helper for proper SVN relpath canonicalization.
Replace ad-hoc trim_start_matches('/') with RelPath::canonicalize().
- Canonicalize URLs in RemoteAccess.__init__() and reparent() to prevent
assertion failures in libsvn.
- Canonicalize URLs in wc.ensure_adm().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.