client: Fix revision parameter parsing when it is set to None#209
Merged
jelmer merged 2 commits intojelmer:mainfrom Mar 19, 2026
Merged
client: Fix revision parameter parsing when it is set to None#209jelmer merged 2 commits intojelmer:mainfrom
jelmer merged 2 commits intojelmer:mainfrom
Conversation
When the revision or peg_revision parameter from numerous client methods is set to None from Python it must be parsed on the rust side as subversion::Revision::Unspecified to avoid unexpected behaviors when calling related client methods. This was the previous behavior with subvertpy < 0.12 with the extension modules written in C. Also the logic to select the right revision when revision or peg_revision parameters are set as unspecified is already handled by the libsvn_subr C library so there is no need to do it from rust.
Client.list and Client.proplist were offering the peg_revision parameter in subvertpy < 0.12 so restore them.
jelmer
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
revisionorpeg_revisionparameter from numerous client methodsis set to
Nonefrom Python it must be parsed on the rust side assubversion::Revision::Unspecifiedto avoid unexpected behaviors whencalling related client methods.
This was the previous behavior with
subvertpy < 0.12with the extensionmodules written in C.
Also the logic to select the right revision when revision or peg_revision
parameters are set as unspecified is already handled by the
libsvn_subrC library so there is no need to do it from rust.
Fixes #208.
I also noticed a couple of client methods were no longer offering the
peg_revisionparameter in 0.12 while they were in 0.11 so I restore them in another commit.