Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add report test coverage module #790

Closed
wants to merge 4 commits into from
Closed

Feat/add report test coverage module #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
405b627
feat: configure jacoco agent preparation
ahmad-kashkoush Feb 10, 2025
36736e7
feat: add argLine to test plugins
ahmad-kashkoush Feb 10, 2025
ebe453c
feat: create a report-aggregate module
ahmad-kashkoush Feb 10, 2025
6b64eca
Merge remote-tracking branch 'origin' into feat/add-report-test-cover…
ahmad-kashkoush Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added org.jacoco.agent-0.8.12-runtime.jar
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not commit binary files. Maven plugin must be used. The CLI on the issue was just an example

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix it, anything else?

Binary file not shown.
Binary file added org.jacoco.cli-0.8.12-nodeps.jar
View file
Open in desktop
Binary file not shown.
2 changes: 2 additions & 0 deletions plugin-modernizer-cli/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>${surefireArgLine}</argLine>
<excludes>
<exclude>**/*ITCase.java</exclude>
</excludes>
Expand All @@ -166,6 +167,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<argLine>${surefireArgLine}</argLine>
<groups>Always</groups>
</configuration>
<executions>
Expand Down
1 change: 1 addition & 0 deletions plugin-modernizer-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>${surefireArgLine}</argLine>
<environmentVariables>
<RUN_IN_MAVEN>true</RUN_IN_MAVEN>
<GH_TOKEN>fake-token</GH_TOKEN>
Expand Down
42 changes: 42 additions & 0 deletions plugin-modernizer-report/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>io.jenkins.plugin-modernizer</groupId>
<artifactId>plugin-modernizer-pom</artifactId>
<version>${changelist}</version>
</parent>

<artifactId>plugin-modernizer-report</artifactId>
<name>Plugin Modernizer Report</name>
<dependencies>
<dependency>
<groupId>io.jenkins.plugin-modernizer</groupId>
<artifactId>plugin-modernizer-cli</artifactId>
<version>${changelist}</version>
</dependency>
<dependency>
<groupId>io.jenkins.plugin-modernizer</groupId>
<artifactId>plugin-modernizer-core</artifactId>
<version>${changelist}</version>
</dependency>
</dependencies>
<build>
<plugins>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>${jacoco-maven-plugin.version}</version>
<executions>
<execution>
<id>report-aggregate</id>
<goals>
<goal>report-aggregate</goal>
</goals>
<phase>verify</phase>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
33 changes: 33 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
<modules>
<module>plugin-modernizer-cli</module>
<module>plugin-modernizer-core</module>
<module>plugin-modernizer-report</module>
</modules>

<properties>
Expand Down Expand Up @@ -436,6 +437,38 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>${jacoco-maven-plugin.version}</version>
<executions>
<execution>
<goals>
<goal>prepare-agent</goal>
</goals>
<phase>initialize</phase>
<configuration>
<propertyName>surefireArgLine</propertyName>
<dumpOnExit>true</dumpOnExit>
<append>true</append>
<output>tcpserver</output>
</configuration>
</execution>
<execution>
<id>prepare-agent-integration</id>
<goals>
<goal>prepare-agent-integration</goal>
</goals>
<phase>pre-integration-test</phase>
<configuration>
<propertyName>surefireArgLine</propertyName>
<dumpOnExit>true</dumpOnExit>
<append>true</append>
<output>tcpserver</output>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down