Skip to content

Add cloudbees-developers to saml#4882

Merged
timja merged 1 commit intojenkins-infra:masterfrom
jglick:patch-2
Jan 7, 2026
Merged

Add cloudbees-developers to saml#4882
timja merged 1 commit intojenkins-infra:masterfrom
jglick:patch-2

Conversation

@jglick
Copy link
Contributor

@jglick jglick commented Jan 7, 2026

Link to GitHub repository

https://github.com/orgs/jenkinsci/teams/saml-plugin-developers seems to be empty (perhaps since #4791?) so I am not sure who could merge something like jenkinsci/saml-plugin#576.

When modifying release permission

Adding https://github.com/orgs/jenkinsci/teams/company-cloudbees-developers since I am not sure what else to do.

Reviewer checklist

  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

@jglick jglick requested a review from a team as a code owner January 7, 2026 17:00
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no team members then its up for adoption so go for it.

@timja timja merged commit 8af9162 into jenkins-infra:master Jan 7, 2026
3 checks passed
@daniel-beck
Copy link
Contributor

daniel-beck commented Jan 7, 2026

If there's no team members then its up for adoption so go for it.

Per https://www.jenkins.io/doc/developer/publishing/source-code-hosting/, @mdonohue and @benmccann have write and admin access, respectively. Teams are not the only way for people to have commit access. We have never before used GH teams as an indicator of maintainedness that I'm aware of, and if we have, we need to review those uses. One of the uses of these YAML files is to specify who the maintainers are, and that's independent of their GH accounts.

@mdonohue
Copy link

Thanks for checking in! I wrote a lot of Hudson plugins in the early days, but haven't been involved with either Hudson or Jenkins for about 15 years now. I don't recall working on a permissions updater at all, but perhaps it was derived from one of my other plugins.

@timja
Copy link
Member

timja commented Jan 10, 2026

Thanks for checking in! I wrote a lot of Hudson plugins in the early days, but haven't been involved with either Hudson or Jenkins for about 15 years now. I don't recall working on a permissions updater at all, but perhaps it was derived from one of my other plugins.

The permissions defined here were created in 2016 based on who had previously released a plugin. So if you had ever released the saml plugin you would have had permissions on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants