Add cloudbees-developers to saml#4882
Conversation
timja
left a comment
There was a problem hiding this comment.
If there's no team members then its up for adoption so go for it.
Per https://www.jenkins.io/doc/developer/publishing/source-code-hosting/, @mdonohue and @benmccann have write and admin access, respectively. Teams are not the only way for people to have commit access. We have never before used GH teams as an indicator of maintainedness that I'm aware of, and if we have, we need to review those uses. One of the uses of these YAML files is to specify who the maintainers are, and that's independent of their GH accounts. |
This reverts commit 8af9162.
|
Thanks for checking in! I wrote a lot of Hudson plugins in the early days, but haven't been involved with either Hudson or Jenkins for about 15 years now. I don't recall working on a permissions updater at all, but perhaps it was derived from one of my other plugins. |
The permissions defined here were created in 2016 based on who had previously released a plugin. So if you had ever released the saml plugin you would have had permissions on it. |
Link to GitHub repository
https://github.com/orgs/jenkinsci/teams/saml-plugin-developers seems to be empty (perhaps since #4791?) so I am not sure who could merge something like jenkinsci/saml-plugin#576.
When modifying release permission
Adding https://github.com/orgs/jenkinsci/teams/company-cloudbees-developers since I am not sure what else to do.
Reviewer checklist
$pluginId Developersteam hasAdminpermissions while granting the access.@Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.There are IRC Bot commands for it.