-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Homebrew #3728
Include Homebrew #3728
Conversation
jenkins-x/homebrew-jx is the homebrew repo for installing the jx client for Jenkins X
Hi @tgelpi. Thanks for your PR. I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/assign @msvticket |
/assign @babadofar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell casks are note supported on linux. In any case this cask doesn't work on linux
@msvticket Removed brew (Linux) from doc as per your call out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there already is a separate section for macOS I'd say you should put the homebrew instructions first in that section.
Quality Gate passedIssues Measures |
@msvticket Updated MacOS section as per your call out. |
/ok-to-test |
⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3728 here |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msvticket The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Failed to merge this PR due to:
|
jenkins-x/homebrew-jx is the homebrew repo for installing the jx client for Jenkins X
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist: