Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Homebrew #3728

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Include Homebrew #3728

merged 4 commits into from
Mar 11, 2024

Conversation

tgelpi
Copy link
Contributor

@tgelpi tgelpi commented Mar 8, 2024

jenkins-x/homebrew-jx is the homebrew repo for installing the jx client for Jenkins X

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist:

  • I have mentioned the appropriate type(scope), as referenced here in the commit message and PR title for the semantic checks to pass.
  • I have signed off the commit, as per instructions mentioned here.
  • Any dependent changes have already been merged.

jenkins-x/homebrew-jx is the homebrew repo for installing the jx client for Jenkins X
@jenkins-x-bot
Copy link
Contributor

Hi @tgelpi. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@tgelpi
Copy link
Contributor Author

tgelpi commented Mar 8, 2024

/assign @msvticket

@tgelpi
Copy link
Contributor Author

tgelpi commented Mar 8, 2024

/assign @babadofar

Copy link
Member

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell casks are note supported on linux. In any case this cask doesn't work on linux

@tgelpi
Copy link
Contributor Author

tgelpi commented Mar 9, 2024

@msvticket Removed brew (Linux) from doc as per your call out.

Copy link
Member

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there already is a separate section for macOS I'd say you should put the homebrew instructions first in that section.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tgelpi
Copy link
Contributor Author

tgelpi commented Mar 11, 2024

@msvticket Updated MacOS section as per your call out.

@msvticket
Copy link
Member

/ok-to-test

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3728 here

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit fe2ff3f into jenkins-x:main Mar 11, 2024
3 of 4 checks passed
@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [3728]: [Method Not Allowed]

@tgelpi tgelpi deleted the patch-2 branch March 11, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants