chore(pom): Use recommended core version 2.462.3, and Java 11. #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gounthar
force-pushed
the
plugin-modernizer/upgradetorecommendcoreversion
branch
from
02aef4e to
64b04a7
Compare
gounthar
force-pushed
the
plugin-modernizer/upgradetorecommendcoreversion
branch
from
64b04a7 to
ae7b4a0
Compare
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
Contributor
Author
|
This should solve the build problem on the default branch. |
- Replace NullPointerException catching with proper null checks - Add null validation for launcher channels and plugin wrappers - Use specific IOException instead of broad Exception handling - Store channel references in variables to prevent repeated null calls - Add SpotBugs suppressions for backward compatibility classes Fixes all 12 identified static analysis violations while maintaining backward compatibility and code functionality.
…/upgradetorecommendcoreversion
…/upgradetorecommendcoreversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
appscandevelopers! 👋This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:
Upgrade to the latest recommended core version and ensure the BOM matches the core version
io.jenkins.tools.pluginmodernizer.UpgradeToRecommendCoreVersion
Why is this important?
Jenkins plugins declare a minimum supported Jenkins version.
The minimum Jenkins version is a useful way for plugin developers to indicate the range of Jenkins versions they are willing to support and test.
See the developer documentation to learn more about the recommended minimum Jenkins version.
The current minimum required Jenkins version is
2.462.3, which is why this pull request has been made.If the plugin is already using the plugin bill of materials, then the bill of materials also needs to be updated with the matching
artifactIdfor the minimum required Jenkins version.I can't see any change to the Jenkins version, how come?
This means your plugin POM was already using the
2.462.3version but still required a few adjustments.The checks fail, why?
For security reasons, the Jenkins infrastructure does not execute Jenkinsfiles proposed in pull requests.
Instead, it builds the code using the Jenkinsfile from the default branch.
In this case, the existing Jenkinsfile specifies Java 8, not Java 11, which is causing the check to fail.
To resolve this,
a maintainer can replay the failed build
by substituting the current Jenkinsfile content with our proposed changes using the "replay the build"
feature in Jenkins.
Please let us know if you need any assistance with this process.
Thanks for taking the time to review this PR.
🙏