Skip to content

VMTemplate builder - add max virtual machines limit configuration support #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alwaysharsha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

VMTemplate builder - add max virtual machines limit configuration support #726

alwaysharsha wants to merge 1 commit into from

Conversation

@alwaysharsha
Copy link

@alwaysharsha alwaysharsha commented Nov 11, 2025 •
edited
Loading

  • Added maxVirtualMachinesLimit field to AzureVMTemplateFluent with getter and setter methods
  • Updated AzureVMTemplateBuilder to propagate maxVirtualMachinesLimit during template construction
  • Modified build() method to conditionally set the limit on AzureVMAgentTemplate when provided

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja
Copy link
Member

timja commented Nov 11, 2025

Please fill out testing done, to demonstrate that you've tested it and it does what you need.

@alwaysharsha
feat: add max virtual machines limit configuration support
051bf6b 
- Added maxVirtualMachinesLimit field to AzureVMTemplateFluent with getter and setter methods
- Updated AzureVMTemplateBuilder to propagate maxVirtualMachinesLimit during template construction
- Modified build() method to conditionally set the limit on AzureVMAgentTemplate when provided
@alwaysharsha alwaysharsha force-pushed the hs-vmtemplate-maxlimit branch from c6b8c1a to 051bf6b Compare November 12, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alwaysharsha @timja