Skip to content

[JENKINS-68321] Call Connector.configureLocalRateLimitChecker more consistently #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[JENKINS-68321] Call Connector.configureLocalRateLimitChecker more consistently #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
535bb1d
[JENKINS-68321] Call `Connector.configureLocalRateLimitChecker` more …
jglick Jan 12, 2023
29b6e72
Merge commit '51545c3^' into configureLocalRateLimitChecker-JENKINS-6…
jglick Sep 8, 2023
d29bb7d
Spotless like in #684
jglick Sep 8, 2023
95c770a
Merge commit '51545c3' into configureLocalRateLimitChecker-JENKINS-68321
jglick Sep 8, 2023
cbd5eb0
Merge branch 'master' of https://github.com/jenkinsci/github-branch-s…
jglick Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,7 @@ public void visitSource(String sourceName, SCMSourceObserver observer) throws IO
}

try {
Connector.configureLocalRateLimitChecker(listener, github);
// Input data validation
if (credentials != null && !isCredentialValid(github)) {
String message = String.format(
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,6 +1236,7 @@ private static void retrievePullRequest(
// The probe github will be closed along with the probe.
final GitHub gitHub = Connector.connect(apiUri, credentials);
try {
Connector.configureLocalRateLimitChecker(listener, github);
ensureDetailedGHPullRequest(pr, listener, gitHub, ghRepository);
} finally {
Connector.release(gitHub);
Expand Down Expand Up @@ -1957,6 +1958,7 @@ protected List<Action> retrieveActions(@CheckForNull SCMSourceEvent event, @NonN
GitHub hub = Connector.connect(apiUri, credentials);
try {
Connector.checkConnectionValidity(apiUri, listener, credentials, hub);
Connector.configureLocalRateLimitChecker(listener, github);
try {
ghRepository = hub.getRepository(getRepoOwner() + '/' + repository);
resolvedRepositoryUrl = ghRepository.getHtmlUrl();
Expand Down