-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73242] Don't fail organization scan if a repository errors #790
base: master
Are you sure you want to change the base?
Conversation
I have not added a test case for this, as I'm not too familiar with the test framework.
also, please do let me know if there is anything I should change/etc. as this is my first contribution to a jenkins plugin. |
hey, is there anything blocking this from being merged? I've been forced to use a locally built version of the plugin, as this is a major issue to me, and having to repeatedly go and rebuild on every update is incredibly annoying. |
See [JENKINS-73242](https://issues.jenkins.io/browse/JENKINS-73242). Signed-off-by: solonovamax <[email protected]>
Description
Don't fail organization scan if a repository errors. See JENKINS-73242 for further information.
Implementation details:
Before attempting any checks against the repository, run
GHRepository.getSource()
. This will cause the repository to attempt to populate all the needed data.Sometimes this can fail, such as in the case where a repository was DMCA'd.
If it fails, catch that error and skip the repository.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify