-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to httpclient5 #197
base: master
Are you sure you want to change the base?
Migrate to httpclient5 #197
Conversation
} | ||
} | ||
|
||
private void configureTimeoutAndSsl(HttpClientBuilder clientBuilder) throws NoSuchAlgorithmException, KeyManagementException { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Generally unsafe method calls Warning
} | ||
return items; | ||
} | ||
public ListBoxModel doFillResponseHandleItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
} | ||
return items; | ||
} | ||
public ListBoxModel doFillResponseHandleItems() { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
@QueryParameter String url) { | ||
return HttpRequest.DescriptorImpl.fillAuthenticationItems(project, url); | ||
} | ||
public ListBoxModel doFillProxyAuthenticationItems(@AncestorInPath Item project, |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
|
||
public FormValidation doCheckValidResponseCodes(@QueryParameter String value) { | ||
public FormValidation doCheckValidResponseCodes(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
|
||
public FormValidation doCheckValidResponseCodes(@QueryParameter String value) { | ||
public FormValidation doCheckValidResponseCodes(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
|
||
private final String keyName; | ||
private final String keyName; |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Plaintext password storage Warning
private final String keyName; | ||
@Serial | ||
private static final long serialVersionUID = -4370238820437831639L; | ||
private final String keyName; |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Plaintext password storage Warning
* Migrate imports, classes and methods * Reduce usage of deprecated classes and methods * Minor code cleanup
0c7abef
to
62cefd5
Compare
Jenkins Security Scan alerts are unrelated to these changes and should be adressed in a separate PR. |
It looks like the build failure has nothing to do with your code modification: |
Replaces outdated
httpclient4
with the successorhttpclient5
.Iam well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.
Testing done
mvn clean verify
and some manual testing.Submitter checklist