Skip to content

fix: stage status in case of retries #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: stage status in case of retries #150

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7e69ca
fix: stage status in case of retries
dharanikesav Feb 20, 2025
3c19096
Merge branch 'master' into master
dharanikesav Mar 12, 2025
d68972b
Merge branch 'master' into master
dharanikesav Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/org/jenkinsci/plugins/workflow/pipelinegraphanalysis/StatusAndTiming.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,11 @@
}
}
WarningAction warning = findWorstWarningBetween(firstNode, lastNode);
if (warning != null) {
return GenericStatus.fromResult(warning.getResult());
Result result = run.getResult();
if (warning != null && result != null) {

Check warning on line 305 in src/main/java/org/jenkinsci/plugins/workflow/pipelinegraphanalysis/StatusAndTiming.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 305 is only partially covered, one branch is missing
if(!result.toString().equalsIgnoreCase(GenericStatus.SUCCESS.toString())) {

Check warning on line 306 in src/main/java/org/jenkinsci/plugins/workflow/pipelinegraphanalysis/StatusAndTiming.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 306 is only partially covered, one branch is missing
return GenericStatus.fromResult(warning.getResult());
}
}

// Previous chunk before end. If flow continued beyond this, it didn't fail.
Expand Down
Loading