Skip to content

Conversation

@jglick
Copy link
Member

@jglick jglick commented Feb 26, 2025

@jglick
Copy link
Member Author

jglick commented Feb 26, 2025

Updated to trunk, this fails with

java.lang.NullPointerException: Cannot invoke method call() on null object
	at org.codehaus.groovy.runtime.NullObject.invokeMethod(NullObject.java:91)
	at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:47)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
	at org.codehaus.groovy.runtime.callsite.NullCallSite.call(NullCallSite.java:34)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:116)
	at com.cloudbees.groovy.cps.sandbox.DefaultInvoker.methodCall(DefaultInvoker.java:20)
	at org.jenkinsci.plugins.workflow.cps.LoggingInvoker.methodCall(LoggingInvoker.java:117)
	at org.jenkinsci.plugins.pipeline.modeldefinition.ModelInterpreter.evaluateSequentialStages(ModelInterpreter.groovy:173)

Apparently it is running the old version of evaluateSequentialStages but calling the new version of evaluateStage. And the error does not reproduce the InvalidClassException claimed from #762 (comment) which might be specific to LabelScript even though NoneScript also changed superclass.

Neither ModelStepLoader.getValue nor None.getScript seem to be called during the test. I can insert a static initializer into ModelInterpreter but that seems to be about it. There is no obvious route to a fix.

@jglick jglick added the tests label Feb 26, 2025
@jglick jglick marked this pull request as ready for review February 26, 2025 18:59
@jglick jglick marked this pull request as draft February 26, 2025 19:36
@jglick jglick marked this pull request as ready for review February 26, 2025 20:06
@jglick jglick marked this pull request as draft February 28, 2025 20:36
@jglick
Copy link
Member Author

jglick commented Feb 28, 2025

Might be easier to test this with RJR.

@jglick jglick closed this Feb 28, 2025
@jglick jglick deleted the DeclarativeAgentScript-compat branch February 28, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant