Cake 4.x EntityTrait _properties changed to _fields #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 19, 2020 13:58
|
Fixed that unit test warning I mentioned earlier. All passing green now! |
jeremyharris
approved these changes
Feb 20, 2020
|
Thanks for the PR, much appreciated! I'll get travis working again (it got turned off somehow) and tag this ASAP. |
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 100% 100%
Complexity 18 18
=======================================
Files 1 1
Lines 44 44
=======================================
Hits 44 44
Continue to review full report at Codecov.
|
|
@KainGNX released: https://github.com/jeremyharris/cakephp-lazyload/releases/tag/4.0.0 Thanks again for the legwork :) |
|
You're welcome! Glad I could help! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been going through a tedious 3.x to 4.x upgrade, and came across this change.
The
EntityTrait::$_propertieshas now becomeEntityTrait::$_fieldshttps://api.cakephp.org/3.8/source-class-Cake.Datasource.EntityTrait.html#29-34
https://github.com/cakephp/cakephp/blob/master/src/Datasource/EntityTrait.php#L37
My unit tests relying on lazy-loading appear to be passing now. Just thought I'd share to help everyone out. :)
PS: I would pick a dev branch if I could.