Skip to content

Major clean-up #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

theredwillow
Copy link

  1. gitignored pycache's: these files are auto-generated at runtime, no need to track them
  2. deleted routes.py: unused routes import made no sense in init_.py. could probably still be improved upon
  3. passing cards as whole objects: no need to pass a gigantic block of variables to the templates when card already defines most of this stuff
  4. simplified cards.py -> deck.py: many of the functions could be rewritten much more simplistically
  5. established card.css: a first step towards separating style concerns
  6. created json files to read: separated content concerns such as card definitions and reading list suggestions out into their own static files
  7. reformatted files: sorry, I didn't know what formatting you were using. added TODO about adding config files for just that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant