-
Notifications
You must be signed in to change notification settings - Fork 36
Major clean-up #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theredwillow
wants to merge
18
commits into
jeremytarling:master
Choose a base branch
from
theredwillow:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theredwillow
commented
Aug 22, 2024
- gitignored pycache's: these files are auto-generated at runtime, no need to track them
- deleted routes.py: unused routes import made no sense in init_.py. could probably still be improved upon
- passing cards as whole objects: no need to pass a gigantic block of variables to the templates when card already defines most of this stuff
- simplified cards.py -> deck.py: many of the functions could be rewritten much more simplistically
- established card.css: a first step towards separating style concerns
- created json files to read: separated content concerns such as card definitions and reading list suggestions out into their own static files
- reformatted files: sorry, I didn't know what formatting you were using. added TODO about adding config files for just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.