Skip to content

Added jerry-ext amalgamation #4992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dmazzella
Copy link
Contributor

Added option to enable jerry-ext amalgamation

@LaszloLango LaszloLango added the enhancement An improvement label Nov 20, 2024
@LaszloLango LaszloLango added this to the Release 3.0.0 milestone Nov 20, 2024
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase it with master, merge the commits into one and add the missing DCO to the end of the commit msg. Otherwise, it looks good to me.

gergocs pushed a commit to gergocs/jerryscript that referenced this pull request Nov 29, 2024
Added option to enable jerry-ext amalgamation

The implementation is based on PR jerryscript-project#4992. Only applied the requested changes
and rebase to master.

Co-authored-by: Damiano Mazzella [email protected]
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
gergocs added a commit to gergocs/jerryscript that referenced this pull request Nov 29, 2024
Added option to enable jerry-ext amalgamation

The implementation is based on PR jerryscript-project#4992. Only applied the requested changes
and rebase to master.

Co-authored-by: Damiano Mazzella [email protected]
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
@robertsipka
Copy link
Contributor

I'm closing it because the requests have been addressed here: #5184

LaszloLango pushed a commit that referenced this pull request Dec 3, 2024
Added option to enable jerry-ext amalgamation

The implementation is based on PR #4992. Only applied the requested changes
and rebase to master.

Co-authored-by: Damiano Mazzella [email protected]
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants