Skip to content

Fix race condition when starting several command tasks in quick succession #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

stefanhaller
Copy link
Collaborator

  • PR Description

Fixes #4507, see there for an elaborate description of the problem.

Labeled as ignore-for-release since this fixes a regression that was only introduced after the last release.

@stefanhaller stefanhaller added the ignore-for-release This will exclude the PR from release notes label Apr 27, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 829aa3c1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (829aa3c) Report Missing Report Missing Report Missing
Head commit (3302a09) 55899 48502 86.77%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4518) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@stefanhaller
Copy link
Collaborator Author

This was approved privately on Discord by @jesseduffield, so I'm just going to merge this.

@stefanhaller stefanhaller merged commit 8bbfd4b into master Apr 27, 2025
14 checks passed
@stefanhaller stefanhaller deleted the fix-race-condition-with-command-tasks branch April 27, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release This will exclude the PR from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hang when showing diffs
1 participant