Hide the cursor when the password prompt is showing

[stefanhaller]

The cursor is a bit of a security concern, because it reveals the length (and typing pattern) of the password.

Resolves #4877.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 0d5a4101	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (0d5a410)	Report Missing	Report Missing	Report Missing
Head commit (235f413)	57738	50195	86.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#4878)	1	1	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[heysokam]

Would it be possible for the behavior to be a configurable option?
While it is a security concern in certain situations, I can see the usefulness of seeing where your cursor lies while typing in regular situations.
So I can imagine this being a non-issue for most people.

Maybe having a configuration option could be the best of both worlds? 🤔

[stefanhaller]

I don't think that's necessary. While it might seem strange at first that you don't get any visual feedback that you are typing something, that's the point after all. And if you get a password prompt on the console, you don't see anything either. I think that's ok.