chore: update typescript #15566
Merged
chore: update typescript #15566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
commented
Apr 6, 2025
| @@ -125,6 +125,7 @@ export async function watchmanCrawl(options: CrawlerOptions): Promise<{ | |||
|
|
|||
| const cmd = <T>(...args: Array<any>): Promise<T> => | |||
| new Promise((resolve, reject) => | |||
| // @ts-expect-error: client is typed strictly, but incomplete | |||
There was a problem hiding this comment.
DefinitelyTyped/DefinitelyTyped#71648
Very nice, but makes it harder to type when we wrap in promise (including node's promisify)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hopefully unblocks #15478
Test plan