fix!: Remove Async from TransactAsync, TransactExAsync #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
remove-transactasync
branch
from
4a71ca2 to
52330a0
Compare
bartelink
commented
Aug 13, 2023
bartelink
force-pushed
the
remove-transactasync
branch
from
e62bb8a to
331e326
Compare
bartelink
force-pushed
the
remove-transactasync
branch
2 times, most recently
from
2a212e7 to
a84d02a
Compare
bartelink
force-pushed
the
remove-transactasync
branch
from
f741365 to
1d642c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another run at #314
Having >10 overloads of transact has pros and cons; the seriousness of the cons is largely dependent on the IDE
While the single change I had to make to the consumption in this repo seems innocuous, IME it can be excruciating to resolve when you're just trying to make something work.
So I'm still not sure if it should actually be done...