Skip to content

[VC-33564] Add a Firefly clusterrole and clusterrolebinding to the venafi-kubernetes-agent chart #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[VC-33564] Add a Firefly clusterrole and clusterrolebinding to the venafi-kubernetes-agent chart #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions deploy/charts/venafi-kubernetes-agent/templates/rbac.yaml
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to install the RBAC for viewing Firefly custom resources on clusters without Firefly CRD installed.

Original file line number Diff line number Diff line change
Expand Up @@ -288,3 +288,30 @@ subjects:
- kind: ServiceAccount
name: {{ include "venafi-kubernetes-agent.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: {{ include "venafi-kubernetes-agent.fullname" . }}-firefly-reader
labels:
{{- include "venafi-kubernetes-agent.labels" . | nindent 4 }}
rules:
- apiGroups: ["firefly.venafi.com"]
resources:
- issuers
verbs: ["get", "list", "watch"]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "venafi-kubernetes-agent.fullname" . }}-firefly-reader
labels:
{{- include "venafi-kubernetes-agent.labels" . | nindent 4 }}
roleRef:
kind: ClusterRole
name: {{ include "venafi-kubernetes-agent.fullname" . }}-firefly-reader
apiGroup: rbac.authorization.k8s.io
subjects:
- kind: ServiceAccount
name: {{ include "venafi-kubernetes-agent.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}