Skip to content

Commit

Permalink
defer H3 to after #12742
Browse files Browse the repository at this point in the history
Signed-off-by: Ludovic Orban <[email protected]>
  • Loading branch information
lorban committed Feb 13, 2025
1 parent 60a1fc1 commit 87206d9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import org.eclipse.jetty.quic.common.QuicStreamEndPoint;
import org.eclipse.jetty.util.Attachable;
import org.eclipse.jetty.util.Callback;
import org.eclipse.jetty.util.ExceptionUtil;
import org.eclipse.jetty.util.NanoTime;
import org.eclipse.jetty.util.Promise;
import org.eclipse.jetty.util.thread.AutoLock;
Expand Down Expand Up @@ -61,28 +60,6 @@ public HTTP3Stream(HTTP3Session session, QuicStreamEndPoint endPoint, boolean lo
this.local = local;
}

public Callback cancel(Throwable cause, Callback callback)
{
Callback nested = new Callback.Nested(callback)
{
@Override
public void succeeded()
{
super.failed(cause);
}

@Override
public void failed(Throwable x)
{
ExceptionUtil.addSuppressedIfNotAssociated(cause, x);
super.failed(cause);
}
};
// TODO does this guarantee that all buffers previously passed will be immediately released?
reset(HTTP3ErrorCode.REQUEST_CANCELLED_ERROR.code(), cause);
return nested;
}

public QuicStreamEndPoint getEndPoint()
{
return endPoint;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ public void send(MetaData.Request request, MetaData.Response response, boolean l
@Override
public Runnable cancelSend(Throwable cause, Callback appCallback)
{
return () -> stream.cancel(cause, appCallback).failed(cause);
// TODO Implement after #12742 is merged
appCallback.failed(new UnsupportedOperationException("Implement after #12742 is merged"));
return () -> {};
}

private void sendHeaders(MetaData.Request request, MetaData.Response response, ByteBuffer content, boolean lastContent, Callback callback)
Expand Down

0 comments on commit 87206d9

Please sign in to comment.