Add new SVG CSS transform and preserve 3d recipe. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregwhitworth
requested changes
Sep 21, 2017
| { | ||
| var nodeName = element.nodeName; | ||
|
|
||
| if (nodeName == "svg") |
There was a problem hiding this comment.
This will only allow <svg> to be looked at. What if the transform is on a different element. I'm trying to track down every possible element that it can be on but the spec doesn't seem clear here so I'll sync up with Bogdan on this.
There was a problem hiding this comment.
Just noticed that you're adding children to the elementsToCheck array, not sure if we should do it this way since recipes will pass in every element. So you should be able to just check that the nodeName is contained within an array that contains various SVG elements (which I'll get to you after chatting with Bogdan) like this:
if (elementToCheck.includes(nodeName))
… comments and IM chat with Greg.
…each individual value. Changed test to have different transforms applied on the g and text elements respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a Crawler recipe to count the number of svg elements on each page and then also indicate how many of these have the transform CSS property applied and the transform-style CSS property applied with value "preserve-3d" in their namespace.
I ran this recipe against a small list of URLs and it seemed to work okay.