-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ante-ls goto definition #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you once again!
@ehllie do you mind tackling the Send errors with the futures next? Since one of the previous PRs I've been getting many of the following errors when building ante-ls:
|
Ah, never mind. I did a get reset without also stashing. Should not have merged this PR. I'm going to revert this, then can you fix the compiler errors? I'm going to add a CI test that ante-ls builds as well since it seems it is not being checked. |
That's odd, I did not get any errors while building |
This reverts commit ec4ae4b.
Implements goto definition capability, and prevents the ls from panicking when the open document is empty. Also refactoring of utility functions to a separate module.