hiding visibility of internal symbols (intel#67)

* hiding visibility of internal symbols * hiding visibility of internal symbols
jfedorov · Jun 12, 2023 · a292b76 · a292b76
1 parent 3bf9f4f
commit a292b76
Show file tree

Hide file tree

Showing 20 changed files with 62 additions and 195 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.49.8
+0.49.9
diff --git a/build_utils/CMakeLists.txt b/build_utils/CMakeLists.txt
@@ -14,8 +14,13 @@ macro(RequirePythonInterp)
 endmacro()
 
 macro(SetCompilerFlags)
+  if(WIN32)
+    set(ADD_FLAGS " ")
+  else()
+    set(ADD_FLAGS " -fvisibility=hidden")
+  endif()
   file(STRINGS "${PTI_CMAKE_MACRO_DIR}/../VERSION" PTI_VERSION)
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DPTI_VERSION=${PTI_VERSION}")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ADD_FLAGS} -DPTI_VERSION=${PTI_VERSION}")
 endmacro()
 
 macro(SetBuildType)

diff --git a/loader/init.cc b/loader/init.cc
@@ -13,7 +13,7 @@ void AtExit() {
   DisableProfiling();
 }
 
-extern "C" __declspec(dllexport)
+extern "C" PTI_EXPORT
 DWORD Init(void*) {
   atexit(AtExit);
   EnableProfiling();

diff --git a/samples/cl_debug_info/tool.cc b/samples/cl_debug_info/tool.cc
@@ -10,28 +10,19 @@ static ClDebugInfoCollector* collector = nullptr;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./cl_debug_info[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {}
 
 // Internal Tool Functionality ////////////////////////////////////////////////

diff --git a/samples/cl_gpu_metrics/tool.cc b/samples/cl_gpu_metrics/tool.cc
@@ -46,28 +46,19 @@ static std::chrono::steady_clock::time_point start;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./cl_gpu_metrics[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {}
 
 // Internal Tool Functionality ////////////////////////////////////////////////

diff --git a/samples/cl_gpu_query/tool.cc b/samples/cl_gpu_query/tool.cc
@@ -15,28 +15,19 @@ static std::chrono::steady_clock::time_point start;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./cl_gpu_query[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {}
 
 // Internal Tool Functionality ////////////////////////////////////////////////

diff --git a/samples/cl_hot_functions/tool.cc b/samples/cl_hot_functions/tool.cc
@@ -21,28 +21,19 @@ static std::chrono::steady_clock::time_point start;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./cl_hot_functions[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {}
 
 // Internal Tool Functionality ////////////////////////////////////////////////

diff --git a/samples/cl_hot_kernels/tool.cc b/samples/cl_hot_kernels/tool.cc
@@ -20,28 +20,19 @@ static std::chrono::steady_clock::time_point start;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./cl_hot_functions[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {}
 
 // Internal Tool Functionality ////////////////////////////////////////////////

diff --git a/samples/gpu_inst_count/tool.cc b/samples/gpu_inst_count/tool.cc
@@ -10,28 +10,19 @@ static GpuInstCountCollector* collector = nullptr;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./gpu_inst_count[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {
   utils::SetEnv("ZET_ENABLE_API_TRACING_EXP", "1");
   utils::SetEnv("ZET_ENABLE_PROGRAM_INSTRUMENTATION", "1");

diff --git a/samples/gpu_perfmon_read/tool.cc b/samples/gpu_perfmon_read/tool.cc
@@ -10,28 +10,19 @@ static GpuPerfMonCollector* collector = nullptr;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./gpu_perfmon_read[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {
   utils::SetEnv("ZET_ENABLE_API_TRACING_EXP", "1");
   utils::SetEnv("ZET_ENABLE_PROGRAM_INSTRUMENTATION", "1");

diff --git a/samples/ze_debug_info/tool.cc b/samples/ze_debug_info/tool.cc
@@ -10,28 +10,19 @@ static ZeDebugInfoCollector* collector = nullptr;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./ze_debug_info[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {
   utils::SetEnv("ZE_ENABLE_TRACING_LAYER", "1");
 }

diff --git a/samples/ze_hot_functions/tool.cc b/samples/ze_hot_functions/tool.cc
@@ -12,28 +12,19 @@ static std::chrono::steady_clock::time_point start;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./ze_hot_functions[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {
   utils::SetEnv("ZE_ENABLE_TRACING_LAYER", "1");
 }

diff --git a/samples/ze_hot_kernels/tool.cc b/samples/ze_hot_kernels/tool.cc
@@ -16,28 +16,19 @@ static std::chrono::steady_clock::time_point start;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./ze_hot_kernels[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {
   utils::SetEnv("ZE_ENABLE_TRACING_LAYER", "1");
 }

diff --git a/samples/ze_metric_query/tool.cc b/samples/ze_metric_query/tool.cc
@@ -45,28 +45,19 @@ static std::chrono::steady_clock::time_point start;
 
 // External Tool Interface ////////////////////////////////////////////////////
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void Usage() {
   std::cout <<
     "Usage: ./ze_metric_query[.exe] <application> <args>" <<
     std::endl;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 int ParseArgs(int argc, char* argv[]) {
   return 1;
 }
 
-extern "C"
-#if defined(_WIN32)
-__declspec(dllexport)
-#endif
+extern "C" PTI_EXPORT
 void SetToolEnv() {
   utils::SetEnv("ZE_ENABLE_TRACING_LAYER", "1");
   utils::SetEnv("ZET_ENABLE_METRICS", "1");