RTECO-1574 - RTECO-1574 - Implementation of Nuget Support for client - - #515
Draft
bhanurp wants to merge 6 commits into
Draft
RTECO-1574 - RTECO-1574 - Implementation of Nuget Support for client -#515bhanurp wants to merge 6 commits into
bhanurp wants to merge 6 commits into
Conversation
**Source:** https://jfrog-int.atlassian.net/browse/RTECO-1574 - Start working on Nuget V2, V3 support for Nuget package manager in jfrog cli. - Make sure PRs are manageable and code is written in a way it can be reused across the clients - Add support for nugetV3 and nugetV2 - refer to [unsupported block: inlineCard] ## Things to consider while implementing - Use JFROG_CLI_NATIVE_IMPLEMENTATION support since nuget is already supported when this is set it routes via native package manager(flexpack). - BuildInfo collection in build-info-go - check sum calculation - Original Deployment Repository calculation - Requested By calculation for dependencies - Easy authentication using nuget’s credentials like mentioned in above Atlassian wiki. - Build Info collection for both dependencies and artifacts for all the commands eligible listed in above wiki. - Set properties clearly on artifacts published. - Make sure the buildinfo is figuring out and showing show in tree in build info section when published to artifactory. ## Not to implement - nuget-config support is not required since this is flexpack implementation. **Parent:** RTECO-395 **Components:** jfrog-cli-nuget Task: RTECO-1574
- Split pack and push into separate collection paths: push now identifies exactly the packages the command uploaded from its own arguments and stamps build.name/build.number/build.timestamp on their exact Artifactory paths, while pack records packages produced since a pre-command snapshot (correctly handling custom --output directories and bin/<Configuration> defaults) without ever re-running or duplicating the native command. - Fixed 'dotnet nuget push'/'nuget push' failing outright with "Source parameter was not specified": the native push command requires an explicit --source/-Source even when --configfile defines exactly one source, but that flag was never being passed. Added it (reusing the existing JFrogCli source alias) whenever the user hasn't already supplied their own --source. - restore now determines and passes its actual target (solution/project/ directory) to the dependency collector, instead of assuming the working directory, so build-info is collected for the project the user actually restored. - Bump the build-info-go replace to the pushed RTECO-1574 commit, which fixes: packages.config checksum/scope/cache-miss gaps, the flat (not nested) NuGet push storage path assumption that broke property stamping, a restore-vs-push module identity mismatch that split one project into two disconnected build-info modules, and missing .slnx (modern XML solution format) support that silently produced empty build info. Verified live against a real Artifactory server (restore, pack, push, and property stamping) in addition to the existing unit test suite.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Points at bhanurp/build-info-go@74d0864 (mergeArtifacts Name+SHA1 check, requestedBy shape scoped to FlexPack's module-ID convention). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
# Conflicts: # go.mod # go.sum
…merge) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by workbench RTECO-1574.
RTECO-1574 - Implementation of Nuget Support for client -
Source: https://jfrog-int.atlassian.net/browse/RTECO-1574
Things to consider while implementing
Not to implement
Parent: RTECO-395
Components: jfrog-cli-nuget
Evidence: see Artifactory bundle for RTECO-1574.
Jira: https://jfrog-int.atlassian.net/browse/RTECO-1574