Skip to content

Diff scan #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 58 commits into
base: dev
Choose a base branch
from
Open

Diff scan #389

wants to merge 58 commits into from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Mar 11, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

Adding a diff mode to audit indicated by 2 new params:

  • diffMode
  • resultsToCompare
  1. if provided only diffMode the sca will not run and will only generate SBOM information
  2. if both provided:
    • for SCA we will get the SBOM, compare using the provided SBOM of the similar target and will only scan the dependencies that exists in the current and not the provided
    • for JAS the return result will already contain the diff (calculated by the analyzer manager)

@attiasas attiasas added the ignore for release Automatically generated release notes label Mar 11, 2025
@attiasas attiasas marked this pull request as draft March 16, 2025 08:47
@attiasas attiasas marked this pull request as ready for review March 19, 2025 11:38
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 12, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 12, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 12, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 12, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 12, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 12, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 12, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 12, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 13, 2025
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 15, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants