fix: preserve colon package names in catalog label assignments - #417
Open
omribz156 wants to merge 1 commit into
Open
fix: preserve colon package names in catalog label assignments#417omribz156 wants to merge 1 commit into
omribz156 wants to merge 1 commit into
Conversation
soumyas-dev
added a commit
that referenced
this pull request
Jun 9, 2026
soumyas-dev
added a commit
that referenced
this pull request
Jul 10, 2026
srinivasgowda097
added a commit
that referenced
this pull request
Jul 14, 2026
fix: preserve colon package names in catalog label assignments(#417)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
package:type:versionstring keys in catalog label version-assignment state/update handling with a structured key.:(for example Maven coordinates such asmysql:mysql-connector-java) when adding, changing, or removing version assignments.Verification:
go test ./pkg/xray/resource -run '^TestNewVersionAssignmentKeyKeepsColonPackageNameIntact$' -count=1go test ./pkg/xray/resource -run '^$' -count=1go test ./pkg/... -run '^$' -count=1git diff --checkNot run:
XRAY_URLorJFROG_URL.This was implemented with Codex assistance, with the patch kept focused and manually reviewed.
Closes #415