Make db_sync_updates_time optional in xray_settings resource - #426
Open
System-Arch wants to merge 2 commits into
Open
Make db_sync_updates_time optional in xray_settings resource#426System-Arch wants to merge 2 commits into
System-Arch wants to merge 2 commits into
Conversation
shahiinn
reviewed
Jun 18, 2026
shahiinn
reviewed
Jun 18, 2026
System-Arch
had a problem deploying
to
development
June 18, 2026 12:13 — with 
GitHub Actions
Failure
GitHub Actions
Failure
System-Arch
force-pushed
the
fix-xray-settings-optional-dbsync
branch
from
July 31, 2026 11:44
90fb7a7 to
371c352
Compare
Change db_sync_updates_time from Required to Optional+Computed. When omitted, Create and Update skip the PUT to the DB sync endpoint and read the current server value via GET so the Computed attribute is populated in state. Add TestAccSettings_noDbSyncTime acceptance test. Add CHANGELOG entry for 3.1.12.
System-Arch
force-pushed
the
fix-xray-settings-optional-dbsync
branch
from
July 31, 2026 12:12
371c352 to
03a5fc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
db_sync_updates_timefromRequiredtoOptional+Computedso thatxray_settingscan be created without configuring the DB sync schedule. This change makes its behavior consistent with all of the other attributes, which are also 'Optional'.Ref #421
Changes
db_sync_updates_timeis nowOptional+Computedinstead ofRequired.xray/api/v1/configuration/dbsync/timewhendb_sync_updates_timeis null/unknown. In this path, the current server value is read via GET so theComputedattribute is populated in state. The resource ID is set to the static string"settings".TestAccSettings_noDbSyncTimeacceptance test that createsxray_settingswithoutdb_sync_updates_timeand verifies the attribute is populated from the server viaTestCheckResourceAttrSet, plus import state verification.Testing
TestAccSettings_noDbSyncTime— new test covering the omitteddb_sync_updates_timepath (verified: fails without fix, passes with fix)TestAccSettings_basic— existing test covering the explicit-value pathTestAccSettings_DbSyncTime— existing test covering sync time only