Generate the login/logout link server-side instead of with javascript #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a template variable `loggedinuser :: String` which is set to the name of the logged in user if there is a user logged in, and is unset otherwise. This means the login/logout links in the userbox can be generated server-side now, and the javascript previously used is redundant. I changed the userbox code and removed the javascript accordingly. This techically changes the public API, as `filledPageTemplate` now takes a `Maybe User` argument which it didn't take previously. Probably the version in gitit.cabal should be bumped if this change is to be merged.
Owner
|
If I recall, my reason for generating the link with javascript was to make it possible to cache the pages. If it's generated server-side, then the cached page will contain someone else's login/logout link. |
Contributor
Author
|
Okay, that makes sense. Do you think if I did a commit that still added this template variable (and consequently changed the interface of |
Contributor
Author
|
Okay, I went ahead and did this, the new pull request is in #414 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the login/logout link server-side instead of with javascript.
I added a template variable
loggedinuser :: Stringwhich is set to the name of the logged in user if there is a user logged in, and is unset otherwise.This means the login/logout links in the userbox can be generated server-side now, and the javascript previously used is redundant. I changed the userbox code and removed the j
This techically changes the public API, as
filledPageTemplatenow takes aMaybe Userargument which it didn't take previously. Probably the version in gitit.cabal should be