Skip to content

Commit

Permalink
Simplified the test_task_structure() test.
Browse files Browse the repository at this point in the history
  • Loading branch information
jhradilek committed Nov 21, 2024
1 parent 6c40e08 commit c133ea8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 18 deletions.
6 changes: 2 additions & 4 deletions test/test_convert_to_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ def test_task_structure(self):
<body>
<p>Topic introduction</p>
<ol>
<li>First step</li>
<li>Second step</li>
<li>Task step</li>
</ol>
<p>Topic summary</p>
</body>
Expand All @@ -61,6 +60,5 @@ def test_task_structure(self):
self.assertTrue(task.xpath('boolean(/task/title[text()="Topic title"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody)'))
self.assertTrue(task.xpath('boolean(/task/taskbody/context/p[text()="Topic introduction"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/steps/step[1]/cmd[text()="First step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/steps/step[2]/cmd[text()="Second step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/steps/step/cmd[text()="Task step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/result/p[text()="Topic summary"])'))
22 changes: 8 additions & 14 deletions test/test_convert_to_task_generated.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,19 @@ def test_task_structure(self):
<p>Topic introduction</p>
<p outputclass="title"><b>Prerequisites</b></p>
<ul>
<li>First prerequisite</li>
<li>Second prerequisite</li>
<li>Task prerequisite</li>
</ul>
<p outputclass="title"><b>Procedure</b></p>
<ol>
<li>First step</li>
<li>Second step</li>
<li>Task step</li>
</ol>
<p outputclass="title"><b>Verification</b></p>
<ul>
<li>Verification step</li>
</ul>
<p outputclass="title"><b>Troubleshooting</b></p>
<ol>
<li>First troubleshooting step</li>
<li>Second troubleshooting step</li>
<li>Troubleshooting step</li>
</ol>
<p outputclass="title"><b>Next steps</b></p>
<ul>
Expand All @@ -78,12 +75,9 @@ def test_task_structure(self):
self.assertTrue(task.xpath('boolean(/task[@id="example-topic"])'))
self.assertTrue(task.xpath('boolean(/task/title[text()="Topic title"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody)'))
self.assertTrue(task.xpath('boolean(/task/taskbody/prereq/ul/li[1][text()="First prerequisite"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/prereq/ul/li[2][text()="Second prerequisite"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/prereq/ul/li[text()="Task prerequisite"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/context/p[text()="Topic introduction"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/steps/step[1]/cmd[text()="First step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/steps/step[2]/cmd[text()="Second step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/result/ul/li[1][text()="Verification step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/tasktroubleshooting/ol/li[1][text()="First troubleshooting step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/tasktroubleshooting/ol/li[2][text()="Second troubleshooting step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/postreq/ul/li[1][text()="Next step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/steps/step/cmd[text()="Task step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/result/ul/li[text()="Verification step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/tasktroubleshooting/ol/li[text()="Troubleshooting step"])'))
self.assertTrue(task.xpath('boolean(/task/taskbody/postreq/ul/li[text()="Next step"])'))

0 comments on commit c133ea8

Please sign in to comment.